Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GEP-25] Enable Shoot cloudProfile reference as complement to cloudProfileName #922

Merged
merged 2 commits into from
Sep 30, 2024
Merged

[GEP-25] Enable Shoot cloudProfile reference as complement to cloudProfileName #922

merged 2 commits into from
Sep 30, 2024
+306 −21

Conversation

LucaBernstein
Copy link
Member

@LucaBernstein LucaBernstein commented Jul 22, 2024 •
edited
Loading

How to categorize this PR?

/area open-source
/area usability
/kind api-change
/kind enhancement
/platform azure

What this PR does / why we need it:
Make the Azure provider extension aware of the CloudProfile field and the option to provide NamespacedCloudProfile references in the shoot.Spec.CloudProfile.
See also GEP-25 and this PR.

Which issue(s) this PR fixes:
Related to gardener/gardener#9504

Special notes for your reviewer:

Release note:

Enable support for the field `shoot.Spec.CloudProfile` alongside `shoot.Spec.CloudProfileName` and enable the future use of `NamespacedCloudProfile`s.

@LucaBernstein LucaBernstein requested review from a team as code owners July 22, 2024 13:46
@gardener-robot gardener-robot added needs/review Needs review area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/usability Usability related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension platform/azure Microsoft Azure platform/infrastructure reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jul 22, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 22, 2024
@LucaBernstein LucaBernstein mentioned this pull request Jul 22, 2024
Open
46 tasks
@LucaBernstein LucaBernstein marked this pull request as draft July 26, 2024 09:49
@LucaBernstein LucaBernstein force-pushed the gep-25-enable-shoot-spec-cloudprofile branch from 91da8d3 to 5a62ea2 Compare August 9, 2024 08:11
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) and removed size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) labels Aug 9, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 9, 2024
@LucaBernstein LucaBernstein force-pushed the gep-25-enable-shoot-spec-cloudprofile branch from 5a62ea2 to 3c13f60 Compare August 13, 2024 08:15
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 13, 2024
@LucaBernstein LucaBernstein force-pushed the gep-25-enable-shoot-spec-cloudprofile branch from 3c13f60 to c4eb4ce Compare August 13, 2024 13:19
@gardener-robot gardener-robot added the size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) label Aug 13, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 13, 2024
@gardener-robot gardener-robot removed the size/l Size of pull request is large (see gardener-robot robot/bots/size.py) label Aug 13, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 13, 2024
@LucaBernstein LucaBernstein force-pushed the gep-25-enable-shoot-spec-cloudprofile branch from c4eb4ce to b420ada Compare August 13, 2024 13:22
@LucaBernstein LucaBernstein force-pushed the gep-25-enable-shoot-spec-cloudprofile branch from 7a83128 to c108fa8 Compare September 10, 2024 08:38
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) and removed size/l Size of pull request is large (see gardener-robot robot/bots/size.py) labels Sep 10, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 10, 2024
@LucaBernstein
Add NamespacedCloudProfile support to Shoot validation.
b880a75 
Switch from CloudProfile to CloudProfileSpec as a generic foundation for CloudProfile and NamespacedCloudProfile.

Improve log message for possibly artificially crafted CloudProfile from NamespacedCloudProfile in Cluster resource.
@LucaBernstein LucaBernstein force-pushed the gep-25-enable-shoot-spec-cloudprofile branch from c108fa8 to b880a75 Compare September 10, 2024 13:31
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) and removed size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) labels Sep 10, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 10, 2024
@LucaBernstein
Copy link
Member Author

/cc @timuthy

timuthy
timuthy previously requested changes Sep 13, 2024
View reviewed changes
Copy link
Member

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits, rest looks good 👍

pkg/admission/validator/shoot.go Outdated Show resolved Hide resolved
pkg/admission/validator/shoot.go Outdated Show resolved Hide resolved
pkg/admission/validator/shoot_test.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Sep 13, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 13, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 13, 2024
@LucaBernstein LucaBernstein dismissed timuthy’s stale review September 13, 2024 09:42

feedback has been addressed.

@gardener-robot gardener-robot removed the needs/changes Needs (more) changes label Sep 13, 2024
@LucaBernstein LucaBernstein marked this pull request as ready for review September 13, 2024 09:47
timuthy
timuthy approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Sep 13, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 13, 2024
@LucaBernstein LucaBernstein removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Sep 26, 2024
kon-angelo
kon-angelo approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kon-angelo kon-angelo merged commit 6eae0f8 into gardener:master Sep 30, 2024
16 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 30, 2024
@LucaBernstein LucaBernstein deleted the gep-25-enable-shoot-spec-cloudprofile branch September 30, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

@timuthy timuthy timuthy approved these changes

Assignees
No one assigned
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/usability Usability related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@LucaBernstein @timuthy @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot